Improved mobile sidenav

karrot-dev / karrot-frontend

We migrated to https://codeberg.org/karrot/karrot-frontend

https://codeberg.org/karrot/karrot-frontend

427 stars 178 forks source link

Improved mobile sidenav #2663

Closed nicksellen closed 1 year ago

nicksellen commented 1 year ago

Branch deployment: https://sidenav-mobile.dev.karrot.world

What does this PR do?

Nice mobile sidenav!

sidenav

Links to related issues

Checklist

[ ] added a test, or explain why one is not needed/possible...
[ ] no unrelated changes
[ ] asked someone for a code review
[ ] joined #karrot:matrix.org
[ ] added an entry to CHANGELOG.md (description, pull request link, username(s))
[ ] tried out on a mobile device (does everything work as expected on a smaller screen?)

nicksellen commented 1 year ago

@brnsolikyl I rebased this on top of current master branch, and did a few minor tweaks. Looks great! Would be happy to walk through it with you some time, code and/or screenshare.

nicksellen commented 1 year ago

I wonder if we should remove some of this old buttons?

oldbuttons

codecov[bot] commented 1 year ago

Codecov Report

Merging #2663 (7e96881) into master (fa35df1) will decrease coverage by 0.02%. The diff coverage is 98.61%.

@@            Coverage Diff             @@
##           master    #2663      +/-   ##
==========================================
- Coverage   75.86%   75.84%   -0.02%     
==========================================
  Files         384      382       -2     
  Lines       41005    40950      -55     
  Branches     2351     2352       +1     
==========================================
- Hits        31108    31059      -49     
+ Misses       9897     9891       -6

Impacted Files	Coverage Δ
src/sidenav/components/SidenavTitle.vue	`86.41% <98.11%> (+0.26%)`	:arrow_up:
src/base/pages/MainLayout.vue	`97.77% <100.00%> (+2.42%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nicksellen commented 1 year ago

"logout" was left all on it's on in an "account" subheading, so I figured don't need the subheading any more, and put the log out right at the bottom...

I also looked at having some way to show if currently on the page represented by one of the buttons, ... but it's a bit fiddly, as the buttons are used in other contexts (the messages, and notifications ones anyway), where they are sometimes links and sometimes not... so I left that out.

2023-07-18T21:06:41_area