Closed nicksellen closed 10 months ago
Merging #2668 (73058f4) into master (d86fd51) will decrease coverage by
0.26%
. The diff coverage is82.44%
.
@@ Coverage Diff @@
## master #2668 +/- ##
==========================================
- Coverage 75.88% 75.63% -0.26%
==========================================
Files 382 386 +4
Lines 40929 41228 +299
Branches 2348 2347 -1
==========================================
+ Hits 31059 31182 +123
- Misses 9870 10046 +176
Files Changed | Coverage Δ | |
---|---|---|
...ivities/components/ActivityFeedbackItem.stories.js | 0.00% <0.00%> (ø) |
|
src/activities/components/ActivityItem.stories.js | 0.00% <0.00%> (ø) |
|
src/activities/helpers.js | 78.51% <0.00%> (-0.59%) |
:arrow_down: |
src/applications/components/ApplicationItem.vue | 0.00% <0.00%> (ø) |
|
src/feedback/pages/GroupFeedback.vue | 0.00% <0.00%> (ø) |
|
src/messages/components/LatestMessageItem.vue | 0.00% <0.00%> (ø) |
|
src/messages/components/ConversationMessage.vue | 91.85% <50.00%> (-1.21%) |
:arrow_down: |
src/feedback/helpers.js | 70.58% <70.58%> (ø) |
|
src/activities/components/ActivityItem.vue | 92.82% <85.96%> (-1.18%) |
:arrow_down: |
src/feedback/pages/ActivityFeedback.vue | 94.88% <89.28%> (-2.46%) |
:arrow_down: |
... and 23 more |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
See https://community.karrot.world/t/feedback-feature-possibility-to-combine-comments-for-selected-activity-type/1044
What does this PR do?
Reconceives showing activity feedback as an activity view rather than a feedback view. Basically grouped by activity, but it fetches from the activities endpoint now, which now includes the feedback info too.
TODO:
Links to related issues
Checklist