karrot-dev / karrot-frontend

We migrated to https://codeberg.org/karrot/karrot-frontend
https://codeberg.org/karrot/karrot-frontend
428 stars 177 forks source link

Feedback is hidden when place status is not co-operating #2683

Closed dwaxweiler closed 10 months ago

dwaxweiler commented 10 months ago

Steps to reproduce

  1. Create an activity series.
  2. Do at least one activity and give feedback.
  3. ~Delete the activity series.~ Set the place status to something else than "co-operating".
  4. Check the feedback page at that place.

What happens

While the total numbers are shown, the message in a green box with the title "No feedback yet" and the text "This page will be filled once more feedback is available" is shown below instead of feedback entries.

What should happen

The feedback given should stay visible.

nicksellen commented 10 months ago

I just tried to recreate that, and I was able to delete a series, and still see the feedback for that place (I did it here fyi https://dev.karrot.world/#/group/6/place/17/feedback).

However, if I change the place status to something other than active / co-operating, then the feedback does go away, and I can see where it does that in the code.

Could it be that you also changed the status after you deleted the series?

nicksellen commented 10 months ago

Tonight I pushed a change with the deployment so that:

So, see if it behaves how you would expect now, otherwise we can follow up. No rush.

dwaxweiler commented 10 months ago

@nicksellen, superb! I have updated the issue title and description with the status detail. Another Foodsaver and I confirm that it works now. Thanks!

nicksellen commented 10 months ago

Great! ✨