nicksellen
commented
2 months ago Hey, thanks for contributing, a few points:
Student contributions
We have very limited capacity for working with undergrad students - I'm not sure if you're read https://github.com/karrot-dev/karrot-frontend/blob/master/CONTRIBUTE.md or https://community.karrot.world/t/are-you-a-student-who-wants-to-contribute-in-karrot/1449 and followed that guidance first?
It is difficult for us to accept beginner-level code contributions as this always requires lots of support and help. We don't have capacity for that for likely-one-time contributors, so we prefer to focus on contributors that are interested in joining our team for the longer term.
I think we should make this clearer.
PR does not address issue
I tried out your branch, but it does not address the original issue:
A person in my group trying to see a place on the map could not see it very well, so they tried to enlarge it (on the button on the right corner of the map). But doing that shows the whole map of the city with all the places
The best would be to show the enlarged map still focusing on that specific place
here are the steps I took:
- I'm on the place page
- I click the enlarge button in the top right corner
I now have a view of ALL the places, but it is not focused on the specific place I was on.
I see you have implemented the ability to click a place once you are on the map, but that doesn't help the user as described in the original issue.
no unrelated changes
You checked the box that says you have made "no unrelated changes" but this is not true. You have added a travis yml file, and a random file you used to trigger builds?
You also have debugging logging still in the code.
I have not reviewed the code itself given these issues.
Also, to note, we have migrated to codeberg now, so https://codeberg.org/karrot/ is where development should happen. GitHub is just a mirror now.
What does this PR do?
This PR introduces several improvements and bug fixes to the marker selection feature on the interactive map component. The updates include:
Enhanced logic for marker selection to ensure robust state management and event handling.
Refactoring the event emission to utilize update:selectedMarkers, streamlining the interaction between child and parent components.
Additional unit tests to cover new scenarios in marker selection and deselection.
Links to related issues
https://community.karrot.world/t/enlarged-map-of-a-place-does-not-keep-place-in-focus/1457
User story: A person in my group trying to see a place on the map could not see it very well, so they tried to enlarge it (on the button on the right corner of the map). But doing that shows the whole map of the city with all the places
The best would be to show the enlarged map still focusing on that specific place Outcomes (or what needs to be done to move forward): implement, if no objections
Checklist