List of little issues - Githubissues

karser / KarserRecaptcha3Bundle

Google ReCAPTCHA v3 for Symfony

MIT License

162 stars 22 forks source link

List of little issues #2

Closed Nek- closed 5 years ago

Nek- commented 5 years ago

Hello thanks for providing open source a bundle for Recaptcha3, this is really kind. I'm going to try to help with a list of some things that can be improved:

[x] You should not retrieve HTTP_CF_CONNECTING_IP directly. I understand this is on your use case but you probably should have a custom request or an IP resolver. It should not be hardcoded inside the validator
[x] enabled option of form type is useless (is not used and makes no sense)
[ ] It should exist a way to add it to other pages than forms (considering this practice highly improve the power of the captcha)
[x] Unit tests are missing!

karser commented 5 years ago

Thank you for the feedback.

Indeed, there is a chance that IP can be overridden by providing CF-Connecting-IP header if you are not using Cloudflare. The IP resolver would work. What do you mean by custom request?
Setting enabled to false is convenient when it comes to functional and e2e testing.

Nek- commented 5 years ago

The Symfony request may be extended to add some custom stuff. (btw there are standards way to forward ip that are supported by Symfony and may be a better option if also supported by cloudflare, IDK)

For enabled part, the code I linked is useless.

karser commented 5 years ago

It should exist a way to add it to other pages than forms (considering this practice highly improve the power of the captcha)

What do you mean here? I'm using this bundle in API methods as well, but not sure what are other cases?

Nek- commented 5 years ago

For the last part: https://developers.google.com/recaptcha/docs/v3#placement