Alternate host for private INTERNET network (like China)

[Prometee]

Related issue #45

This PR add a new host configuration value, allowing to change the used JS script host into the twig template. It also change the host used to verify the captcha value.

[karser]

Error: Call to undefined method Karser\Recaptcha3Bundle\Tests\FunctionalTest::assertStringContainsString() Our composer.json: "php": ">=7.1" and we need assertStringContainsString in our tests.

phpunit v6.5.14 requires "php": "^7.0" but it doesn't have assertStringContainsString. Only assertContains

phpunit v7.5.19 requires "php": "^7.1" and it supports assertStringContainsString

phpunit v8.5.20 requires "php": ">=7.2", and it supports assertStringContainsString

It should use phpunit v7.5.19 instead of v6.5.14. Let's change "phpunit/phpunit": "^6|^8|^9" to ^7|^8|^9

[karser]

symfony/form[v5.0.0, ..., v5.0.8] require php ^7.2.5 -> your php version (7.1.33) does not satisfy that requirement.

it seems we should avoid testing Symfony 5 with PHP 7.1

[Prometee]

Yes, I will take care of it, I already make exclusion in other repositories. Can you let the GitHub Actions build on my push, it will avoid you checking it until I fix the build. I will force push some commit to avoid a too long list.

[karser]

Done. Now 7.2 failed as well

[karser]

Error: "./composer.json" does not contain valid JSON Parse error on line 59: ...0.1.x-dev" }, }}

[Prometee]

Are you able to let the build auto start on my push ?

[karser]

Are you able to let the build auto start on my push ?

I'm not sure. Do you know how to do that?

[Prometee]

Are you able to let the build auto start on my push ?

I'm not sure. Do you know how to do that?

It should be in the settings of this repository > Actions : https://github.com/karser/KarserRecaptcha3Bundle/settings/actions Choose "Require approval for first-time contributors who are new to GitHub" instead of the second option. it will be less annoying for you and more practical for those who create PR.

[karser]

Are you able to let the build auto start on my push ?

I'm not sure. Do you know how to do that?

It should be in the settings of this repository > Actions : https://github.com/karser/KarserRecaptcha3Bundle/settings/actions Choose "Require approval for first-time contributors who are new to GitHub" instead of the second option. it will be less annoying for you is more practical for those who create PR.

thanks, done!

[karser]

Looks like all is fine. I'm going to merge this and release it. Thank you @Prometee for the work on this PR!

[Prometee]

Thank you too for creating this project, it help us a lot 😉 !

[Prometee]

@karser re-reading the README.md I missed to add www. to the yaml comment ... Can you add it quickly before releasing it ?

[karser]

Thanks, I noticed it too. Fixed it and moved a bit lower.

[Prometee]

Ok, perfect !