search

karser / KarserRecaptcha3Bundle

Google ReCAPTCHA v3 for Symfony
MIT License
158 stars 21 forks source link

chore: allow phpunit 10 #61

Closed Chris53897 closed 1 year ago

Chris53897 commented 1 year ago

Update: After looking at the ci runs, there are some problem with older symfony versions. Should be merged after support of the outdated versions is removed.

karser commented 1 year ago

Hi @Chris53897 , thank you for the PR. I'd rather keep the outdated versions unless there is a strong reason. Tests failed because composer installs phpunit 10 for symfony 3.4/4.4 and php > 8. Can we add the failed php/symfony combinations to the exclude section?

Chris53897 commented 1 year ago

@karser Sorry for the delay. I found another solution. Just not allow phpunit 10 for older symfony versions.

karser commented 1 year ago

Thank you @Chris53897