search

karsumit94 / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
0 stars 0 forks source link

Chart feature broken (in 1.9.4 dev. version) #178

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The chart feature is broken in the current development version.
The problem is that the JS does document.getElementById('content') and there is 
no element with id=content (anylonger).

This issue was introduced with revision #279 (which aimed at issue #94).

If I see this correctly, the element that is meant here (that was <div 
id="content"> before) is now the <td class="right_td">.

Maybe we should use names like "content" again instead of "right_td". And ids 
instead of classes for stuff that is unique (there cannot be a 2nd right_td).

Original issue reported on code.google.com by crazy4ch...@gmail.com on 20 Feb 2013 at 2:16

GoogleCodeExporter commented 9 years ago 
Hmm. Maybe introducing "content" again is not a good idea as it would break all 
themes currently available. They all contain something like:
#content { overflow:hidden; padding-left:10px; }

With the current td-solution, we don't want this anylonger.

Original comment by crazy4ch...@gmail.com on 20 Feb 2013 at 2:23

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r341.

Original comment by crazy4ch...@gmail.com on 20 Feb 2013 at 2:27