Closed GoogleCodeExporter closed 8 years ago
Pull request #22 submitted
Original comment by d.li...@gmail.com
on 30 Sep 2014 at 2:09
Has anybody had a chance to review my pull request? I'm eager to get this
merged into the the main project. If there are any concerns about my change or
tests I can provide, please let me know.
THanks,
Dan
Original comment by d.li...@gmail.com
on 27 Oct 2014 at 1:17
Thanks, merged!
Sorry for the delay, I'm in the middle of my master's thesis so I don't have
much time to deeply review this PR right now.
I don't see any problem in advance, and I'll make a full review and test update
possibly in late November to release a new stable version.
If you can send an additional automatic unit test, that would be useful too.
Thanks again for your contributions, please feel free to close this issue if it
is solved an no regression in the other tests was introduced.
Original comment by reingart@gmail.com
on 27 Oct 2014 at 5:36
This issue was closed by revision 3b14d52f5e8e.
Original comment by reingart@gmail.com
on 27 Oct 2014 at 6:36
Original issue reported on code.google.com by
d.li...@gmail.com
on 29 Sep 2014 at 7:41Attachments: