search

kartagis / pysimplesoap

Automatically exported from code.google.com/p/pysimplesoap
0 stars 0 forks source link

Make Server.dispatch more robust #39

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Currently in dispatch() if there's an error after the invocation of the 
function - during the construction of the return XML - the client will be 
return gibberish rather than a Fault. A simple refactoring allows errors during 
result serialisation (marsalling) to also return a Fault to the client. This is 
attached.

Original issue reported on code.google.com by r1chardj0n3s on 23 Nov 2011 at 11:29

Attachments:

GoogleCodeExporter commented 8 years ago 
Great, thanks. Could you add test cases?

I've made you commiter so you can create a branch and then we can merge this 
changes.

Original comment by reingart@gmail.com on 24 Nov 2011 at 5:28

GoogleCodeExporter commented 8 years ago 
Thanks for the commit privs. I'm a bit confused though - I can't see any place 
in the source that currently holds tests.

Original comment by r1chardj0n3s on 24 Nov 2011 at 5:36

GoogleCodeExporter commented 8 years ago 
I put the (very basic) tests in the python files, section __main__

But yes, it would be useful to extract that tests to a folder or specific files 
(I'm keeping new tests this way, but they aren't commited by now)

Original comment by reingart@gmail.com on 24 Nov 2011 at 1:56

GoogleCodeExporter commented 8 years ago 
I would be much more comfortable adding tests to a more formalised test harness.

Original comment by r1chardj0n3s on 25 Nov 2011 at 12:41

GoogleCodeExporter commented 8 years ago 
Now there's a place for tests.

Original comment by ma...@matee.net on 19 Dec 2011 at 9:34

GoogleCodeExporter commented 8 years ago 
close?

Original comment by oczk...@gmail.com on 17 Aug 2013 at 7:52