kartagis / pysimplesoap

Automatically exported from code.google.com/p/pysimplesoap
0 stars 0 forks source link

Code review request #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:
- ability to add extra namespaces to server response
- change defined namespace aliases to this provided by client in his request

When reviewing my code changes, please focus on:
- SoapDispatcher.dispatch method which adds extra namespaces to response
- namespaces mapping in SimpleXMLElement

Original issue reported on code.google.com by ma...@matee.net on 20 Dec 2011 at 11:30

GoogleCodeExporter commented 8 years ago
Code: 
http://code.google.com/p/pysimplesoap/source/detail?r=aa76a8402cfca21b9564eee434
f25c896fa0f024&name=namespaces

Original comment by ma...@matee.net on 20 Dec 2011 at 11:32

GoogleCodeExporter commented 8 years ago
I don't fully understand why you need this, but if it doesn't broke 
compatibility it's ok for me.

If you can also add tests and wiki docs that would be great.

Does this has any impact on performance (SimpleXmlElement)?

Original comment by reingart@gmail.com on 8 Jan 2012 at 1:29

GoogleCodeExporter commented 8 years ago
It is necessary when we need to generate a response like this in server side.

<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" 
xmlns:zgd="http://www.zigbee.org/zgd/" 
xmlns:gwg="http://www.zigbee.org/GWGSchema">
   <soapenv:Header/>
   <soapenv:Body>
      <zgd:GetVersionResponse>
         <Status>0</Status>
         <!--Optional:-->
         <Version>
            <gwg:VersionIdentifier>1</gwg:VersionIdentifier>
            <gwg:FeatureSetIdentifier>0</gwg:FeatureSetIdentifier>
            <!--1 or more repetitions:-->
            <gwg:RPCProtocol>SOAP</gwg:RPCProtocol>
            <gwg:ManufacturerVersion>"Exegin Gateway Version 0.0"</gwg:ManufacturerVersion>
         </Version>
      </zgd:GetVersionResponse>
   </soapenv:Body>
</soapenv:Envelope>

Original comment by what...@gmail.com on 28 Sep 2012 at 6:26

GoogleCodeExporter commented 8 years ago

Original comment by reingart@gmail.com on 22 Jan 2014 at 2:29