kartaview / android

Android app for collecting KartaView imagery
MIT License
136 stars 31 forks source link

"Source code is not yet up to date"? #153

Open vpzomtrrfrt opened 4 years ago

vpzomtrrfrt commented 4 years ago

Why is there no source code published here since December 2017?

githubber42 commented 4 years ago

(Following) It seems this code is now closed proprietary source, although they still advertise: "free and open platform."

tuxayo commented 4 years ago

For the record, the latest libre/open source release is the v2.1.6 https://github.com/openstreetcam/android/tree/2.1.6

tuxayo commented 4 years ago

@Telenav @openstreetcam This is important, the only reason I was using and advertising OpenStreetCam over Mapillary was that the apps and the website where libre.

It's weird to require users to use closed tools to work, create and collect libre/open data.

PanderMusubi commented 4 years ago

So we close this issue on closedstreetcam?

davidak commented 4 years ago

I asked them to clearify the situation via E-Mail and Twitter.

alexandrui-telenav commented 4 years ago

The Android repo is indeed way behind development, same for openstreetcam.org. Others like upload-scripts and josm-plugin are doing better but still not great. We had to focus lately on some fundamental tech aspects on the platform and maintaining the open source part got deprioritized in the end.

In the coming weeks we’ll have code updates on this repo and others, we don’t have any intention of keeping the platform closed. Sorry for not being as active here as we should've.

alexandrui-telenav commented 4 years ago

So we close this issue on closedstreetcam?

Let's keep it open until actual code update.

PanderMusubi commented 4 years ago

Thanks for the update with good news.

davidak commented 4 years ago

maintaining the open source part got deprioritized in the end.

What's the problem to git push at the end of the workday? Then we see at least that the project is not dead.

532910 commented 4 years ago

https://github.com/openstreetcam/android/issues/153#issuecomment-522945583 --- @telenav replies that it's still opensource.

alexandrui-telenav commented 4 years ago

maintaining the open source part got deprioritized in the end.

What's the problem to git push at the end of the workday? Then we see at least that the project is not dead.

Clean up / small refactoring for external SDK usage, API keys etc. Nothing major but with summer holidays and a small team I can't promise something very very fast. But point well taken.

Project's clearly not dead as we update the app on Google Play quite regularly, it's the Github part we have to do a better job at..

ec1oud commented 4 years ago

I don't use Google Play Store. So that means the latest is still 2.4.0, a year old. Did any improvements get made in the last year?

githubber42 commented 4 years ago

Sorry for not being as active here as we should've.

Going on 2 years since last update, this sounds hollow. Sorry for not being active with my Waylens camera (proprietary) or android app.

mds08011 commented 4 years ago

I don't use Google Play Store. So that means the latest is still 2.4.0, a year old. Did any improvements get made in the last year?

@ec1oud the 2.9.1 .apk is in releases now: https://github.com/openstreetcam/android/releases

camelCaseNick commented 4 years ago

maintaining the open source part got deprioritized in the end.

What's the problem to git push at the end of the workday? Then we see at least that the project is not dead.

Clean up / small refactoring for external SDK usage, API keys etc. Nothing major but with summer holidays and a small team I can't promise something very very fast. But point well taken.

Project's clearly not dead as we update the app on Google Play quite regularly, it's the Github part we have to do a better job at..

You published the 2.9.1 apk with old source code and nothing is happening in the repo? Why do you care so little about open source, that not even a yearly commit is possible?

EDIT: I have to apologize. I didn't find the new 2.9.1 branch. Sorry!

siliconninja commented 4 years ago

Check the release_2.9.1_github branch. I see some updated source code there, the new branch just wasn't announced in this issue. It's not in the default master branch.

Thank you for updating the source code!

zekooooo commented 4 years ago

Hello, have there been updates? I would really like to have OpenStreetCam on F-Droid (#113).

githubber42 commented 4 years ago

@zekooooo 3.0.1 is on play store; only 2.9.1 is on github. It probably won't ever make it to f-droid.

tuxayo commented 4 years ago

v3.0.1 source code seems to have been released not in the repo but in the release page as a source code archive.

Zahnstocher commented 4 years ago

v3.0.1 source code seems to have been released not in the repo but in the release page as a source code archive.

No, this is the very old 2.1.6 code (end of 2017). It is not even the latest available 2.9.1 code: https://github.com/openstreetcam/android/tree/release_2.9.1_github

tuxayo commented 4 years ago

build.grade => appVersionName : "2.1.6",

Ho damn, you are right :(

Yesterday, I just recommended OpenStreetCam at a mapping party just because I though it was libre again T_T

tuxayo commented 4 years ago

Version 3.1.6 just released and it's not libre/open source.

Latest libre/open source one (2.1.6) has version code 86. So by using Aurora Store or Yalp Store it's possible to get it. (menu => manual download => input the version code)

Hopefully version 2.1.6 will still work.

Bibi56 commented 4 years ago

On http://blog.improveosm.org/en/2019/12/openstreetcam-and-improveosm-are-moving-to-grab/ (Dec 2019 about ImproveOSM and OpenStreetCam):

Open Source: Good news, the code license is changing from LGPL to the more permissive MIT license. The imagery license will remain the same, CC BY-SA version 4.

So Open Source, but with a minor defect: the code is missing.

EchedelleLR commented 3 years ago

Then is not Open Source. The Open Source definition that the software, itself, must be Free Software by design --> https://opensource.org/osd

EchedelleLR commented 3 years ago

Version 3.1.6 just released and it's not libre/open source.

Latest libre/open source one (2.1.6) has version code 86. So by using Aurora Store or Yalp Store it's possible to get it. (menu => manual download => input the version code)

Hopefully version 2.1.6 will still work.

You are not the only one...

Extarys commented 3 years ago

Damn I almost felt for the trap. Just discovered "Open"StreetCam, but it's closed source. :angry:

Sad world we live in.

Bibi56 commented 3 years ago

@Extarys, sad yes but the license until 12 Dec 2019 was GNU LESSER GENERAL PUBLIC LICENSE then changed to MIT License.

GNU LESSER GENERAL PUBLIC LICENSE, valid until 3.0.0 at least states: The "Minimal Corresponding Source" for a Combined Work means the Corresponding Source for the Combined Work, excluding any source code for portions of the Combined Work that, considered in isolation, are based on the Application, and not on the Linked Version.

So it is not supposed to be closed code at least until 3.0.0.

For 3.0.1 and following versions, as it is using a GNU LESSER GENERAL PUBLIC LICENSE for its base, IMHO - but I'm not a jurist - the derivative work like 3.1.6 should comply to the previous statement. So at least we are missing the 3.0.0 source code here.

Extarys commented 3 years ago

@Bibi56 What I meant was the current source code in the repo is old (v2.9.1) compared to the current APK. So the latest version is not open source no matter what the license says right now because there is no source. Also, I discovered this yesterday so I didn't have time to investigate the "new" company behind this and make my mind about their reputation and if they should be trusted.

They bought this at the end of last year, so maybe* they'll catch up soon and continue their Open-Source works :crossed_fingers:

chip-grab commented 3 years ago

@Extarys, I have an insight on this that @grab will continue open source work. πŸ˜‰ Updates to come soon. Stay tunned. 🀞

davidak commented 3 years ago

@chip-grab do you have an estimate for a release? we are waiting for 3 years...

zekooooo commented 3 years ago

Happy to hear this @CHip especially in the light of Facebook buying Mapillary.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, September 4, 2020 8:05 PM, CHip notifications@github.com wrote:

@Extarys, I have an insight on this that @grab will continue open source work. πŸ˜‰ Updates to come soon. Stay tunned. 🀞

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mnalis commented 3 years ago

@chip-grab has there been any progress on making the app open-source? If I read it correctly, build.gradle still requires proprietary components in 4.0 (quick glance)?

tuxayo commented 3 years ago

The source code of the repo and the archive from the releases is still the one of version 2.1.6 (version code 86).

So version 4.0 is still not libre/open source

Zahnstocher commented 3 years ago

The source code of the repo and the archive from the releases is still the one of version 2.1.6 (version code 86).

So version 4.0 is still not libre/open source

It is version 4.0, version code 118: https://github.com/kartaview/android/blob/master/build.gradle#L134 It was released on 2 Dec 2020: https://github.com/kartaview/android/commit/ae5b56b80de596612c4f0bea0b54c6e615d21966 I tried to build it a few days later, but I failed. Some things in the code are not defined and it heavily depends on third party libs, some are closed source, some are not available in the repositories and I had to find them myself. Then I found out, that I need API key for Mapbox, so I registered there. For Google (analytics or something like that), I created a dummy API key file. Then I found out, that I need Skobbler API keys, which I don't have. Why is Skobbler dependency still there, I thought it was replaced by the new Mapbox dependency... After several hours I gave up, it was just a waste of time. :cry: I think this open source project is completely broken. I wonder if the developer who committed this code ever tried to build it. :confused:

hamishmb commented 2 years ago

Bump for progress.

hamishmb commented 1 year ago

Bumping again. I'm happy to be of assistance, when I have time and spare executive function (it varies when you have autism).

I could help get this release building, too, and try to get in contact with the devs again, but I can't do these things by myself in any reasonable timescale. Shall we start coordinating something?

chrisdebian commented 1 year ago

Bumping again. I'm happy to be of assistance, when I have time and spare executive function (it varies when you have autism).

I could help get this release building, too, and try to get in contact with the devs again, but I can't do these things by myself in any reasonable timescale. Shall we start coordinating something?

Hamish, I've just opened a new issue, asking for the code and source to be uploaded, as this is a requirement of the OS licence, and will enable people to fork, should they want to review or modify the code.

chrisdebian commented 1 year ago

I received an update, the other day; ver 5.5.1 (150), but I can't see this release on GitHub. Could someone else check, in case I'm being paranoid about open source licenses being contravened.

Thanks,

Chris chris_debian

EchedelleLR commented 1 year ago

Hi, this app is not FLOSS anymore sadly.

hamishmb commented 1 year ago

Any news on this? This is in contravention of the license, so we should be able to do something about it.

chrisdebian commented 1 year ago

Hamish,

I think you're right, but the only way this will get resolved is by contributors moving to another platform, noting Mapillary is owned by FB/ Meta. I proposed a way to address these concerns, in a different ticket. KV are clearly not interested in a 2-way dialogue with contributers.

chris_debian

hamishmb commented 1 year ago

Unfortunately you're probably right. Unless the server side code is open, this might be a bit of a lost cause.

mnalis commented 10 months ago

I received an update, the other day; ver 5.5.1 (150), but I can't see this release on GitHub. Could someone else check, in case I'm being paranoid about open source licenses being contravened.

Hmm, the code was LGPL3 until 2019, when https://github.com/kartaview/android/commit/502b9004eb7ab4f9e67f49f965e560828b0f1210 changed it to MIT license (which is not copyleft, thus cannot guarantee that the code will stay open) ?!

Have all people who ever contributed to the code agreed to this license change? If not, this license change is illegal.

Call to people: if you ever contributed to code of what is now Kartaview, have not given up / transfered you copyright, and disagree with this license change, please comment here or contact me.

davidak commented 10 months ago

@mnalis you can see contributors at https://github.com/kartaview/android/graphs/contributors.

People that contributed before the license change are @james2432, @vdechenaux and @Xevib.

mnalis commented 10 months ago

@mnalis you can see contributors at https://github.com/kartaview/android/graphs/contributors.

@davidak thanks, that indeed lists some of them (and if any of them owns copyright on part of the code and didn't authorize license change I hope they will reply here), however: