kartaview / openstreetcam.org

The openstreetcam.org web site
MIT License
75 stars 10 forks source link

Changing color of roador enhancing contrast and image compression #142

Open smajser opened 7 years ago

smajser commented 7 years ago

I am using map a lot, and I find it very helpful but there is one problem. Contrast between background and streets is very weak and it is quite difficult to see streets clearly.

Is it possible to add feature to enhance contrast or change color of streets by user preferences?

Also it would be good if there is an option to compress images taken by "JPEG recording" before uploading them. A lot of time and bandwidth could be saved with this.

alexandrui-telenav commented 6 years ago

Hi @smajser , are you talking about the map in the app or the website?

smajser commented 6 years ago

Hi Alex,

I am talking about map in app.

G: smajser1 S: uros.racic P: +381 63 45-48-45 L: https://www.linkedin.com/in/uros-racic-0a9555120/ T: @racic_uros

------ Original Message ------ From: "Alex Ilisei" notifications@github.com To: "openstreetcam/openstreetview.org" openstreetview.org@noreply.github.com Cc: "smajser" smajser1@gmail.com; "Mention" mention@noreply.github.com Sent: 2/2/2018 4:42:47 PM Subject: Re: [openstreetcam/openstreetview.org] Changing color of roador enhancing contrast and image compression (#142)

Hi @smajser https://github.com/smajser , are you talking about the map in the app or the website?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openstreetcam/openstreetview.org/issues/142#issuecomment-362621377, or mute the thread https://github.com/notifications/unsubscribe-auth/AdBcbFl5nRLG3xPPkofBD0AUuFBUG34Xks5tQyz3gaJpZM4PXomt.


This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

alexandrui-telenav commented 6 years ago

It's a good point, we're working on a map style that increases the contrast.

On the JPEG encoding suggestion, the reasoning for letting the JPEG mode in there was that on some devices the video encoding is not working well due to OS inconsistencies. Moving that to a later point will still lead to the same problems.. So what's the reason you're recording in JPEG mode in the first place, did you have problems with the default?

smajser commented 6 years ago

No, I did not have any problems with both modes, all work fine. But when I use JPEG my phone takes more pictures. If I could use JPEG mode and then convert to comppressed format, that would benefit in two ways (on my side). First it would reduce upload time (I have 1 MB upload), and second the path would be more detailed. For the second part, I do not find that it is a problem on routes that I go regulary (I can take photos 100 times), but there are roads that are less frequently traveled and that would benefit from ability to take more pictures at once.

G: smajser1 S: uros.racic P: +381 63 45-48-45 L: https://www.linkedin.com/in/uros-racic-0a9555120/ T: @racic_uros

------ Original Message ------ From: "Alex Ilisei" notifications@github.com To: "openstreetcam/openstreetview.org" openstreetview.org@noreply.github.com Cc: "smajser" smajser1@gmail.com; "Mention" mention@noreply.github.com Sent: 3/2/2018 9:32:58 AM Subject: Re: [openstreetcam/openstreetview.org] Changing color of roador enhancing contrast and image compression (#142)

It's a good point, we're working on a map style that increases the contrast.

On the JPEG encoding suggestion, the reasoning for letting the JPEG mode in there was that on some devices the video encoding is not working well due to OS inconsistencies. Moving that to a later point will still lead to the same problems.. So what's the reason you're recording in JPEG mode in the first place, did you have problems with the default?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openstreetcam/openstreetview.org/issues/142#issuecomment-369855797, or mute the thread https://github.com/notifications/unsubscribe-auth/AdBcbBd--TSr9WzZ1eqHX1ZbmIGA8C8-ks5taQO6gaJpZM4PXomt.


This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

alexandrui-telenav commented 6 years ago

Got it. To give you a bit of background, the app doesn't make any difference between JPEG or video modes for the photo trigger, but it's possible that video encoding can't keep up with the recording and then some frames are skipped. Doing a post-JPEG encoding involves some technical difficulties ( whole metadata file needs to be parsed and updated ) and you'd also lose more quality ( both JPEG and h264 are lossy formats, hence double quality loss ). What we think is the better approach here is to optimise the encoding using the native Android API instead of ffmpeg, there's a good chance that recording with video compression will work without skipped frames afterwards. I know this is usually not a solution, but a better Android phone or an iPhone solves this as well as it wouldn't skip frames. Can you share what phone do you use?

smajser commented 6 years ago

Well, I did not think that way, but I understand that part. My phone is Sony Xperia XA

G: smajser1 S: uros.racic P: +381 63 45-48-45 L: https://www.linkedin.com/in/uros-racic-0a9555120/ T: @racic_uros

------ Original Message ------ From: "Alex Ilisei" notifications@github.com To: "openstreetcam/openstreetview.org" openstreetview.org@noreply.github.com Cc: "smajser" smajser1@gmail.com; "Mention" mention@noreply.github.com Sent: 3/2/2018 12:29:50 PM Subject: Re: [openstreetcam/openstreetview.org] Changing color of roador enhancing contrast and image compression (#142)

Got it. To give you a bit of background, the app doesn't make any difference between JPEG or video modes for the photo trigger, but it's possible that video encoding can't keep up with the recording and then some frames are skipped. Doing a post-JPEG encoding involves some technical difficulties ( whole metadata file needs to be parsed and updated ) and you'd also lose more quality ( both JPEG and h264 are lossy formats, hence double quality loss ). What we think is the better approach here is to optimise the encoding using the native Android API instead of ffmpeg, there's a good chance that recording with video compression will work without skipped frames afterwards. I know this is usually not a solution, but a better Android phone or an iPhone solves this as well as it wouldn't skip frames. Can you share what phone do you use?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openstreetcam/openstreetview.org/issues/142#issuecomment-369897388, or mute the thread https://github.com/notifications/unsubscribe-auth/AdBcbA_DJtsvXU3MiY9S6d-EL2F0rehsks5taS0ugaJpZM4PXomt.


This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus