search

kartaview / openstreetcam.org

The openstreetcam.org web site
MIT License
75 stars 10 forks source link

The app ignores device orientation. #175

Open 532910 opened 6 years ago

532910 commented 6 years ago

My device orientation is always locked. But the app ignores it and takes sensor value.

  1. Some images are captures in the wrong orientation due to jolting in the car.
  2. I'm not able to use app laying in the bed. (to upload images or see tracks)
532910 commented 5 years ago

I have no idea why it's close but it's still actual!

532910 commented 5 years ago

Moreover, after some update, it's impossible to use it vertically! Moreover, it's so hard locked, so the usb socket MUST be on the right, and not on the left. You make the app totally unusable for me!

bogdans-telenav commented 5 years ago

@532910 what device, os version and app version do you use? We force a landscape orientation on the recording screen since while you record in landscape you have less sky and more road/ buildings in your images, the quality of the images are better since the camera does not have to focus on a large range of light intensities (sky vs road). Can you please provide step by step info regarding your specific flows that have problems.

532910 commented 5 years ago

Why do you asking about device, os and app versions, while you confirm that "We force a landscape orientation on the recording screen". Yes, this but is exactly about this landscape lock.

I'm not able to use the app more as I never use my phone horizontally.

bogdans-telenav commented 5 years ago

@532910 we have the orientation locked to landscape on both iOS and Android apps and since i don't know what OS you are using or what are the steps to reproduce your problem, we can not try to reproduce them.

532910 commented 5 years ago

OP3T, LineageOS 15.1-20190124 based on Android 8.1.0

  • " I'm not able to use app laying in the bed. (to upload images or see tracks)"? We don't know what are your expectations for this two screens upload images and tracks review? This two screens should work in portrait and landscape on both platforms.

My screen is locked to portrait. When I in the bed, I hold the phone in the portrait mode relative to me, but it's in the landscape relative to the horizon. The app ignores this lock and draws based on the acceleration sensor.

  • "Moreover, after some update, it's impossible to use it vertically!" If you are talking only about the recording this is by design as I already explained. Any other behavior is not intended and if you experience misbehavior please provide some help to reproduce your problems.

Yes, I'm talking about recording here.

  • "I'm not able to use the app more as I never use my phone horizontally." I already emphasized on the importance of the landscape usage while recording. If you believe that you can not use the app in landscape you could record your tracks in portrait, upload them like they are (wrongly orientated) and fix the orientation on the website with the rotate track feature. But our recommendation is that you record your tracks in landscape.

Please, don't tell users how to hold their phones. I make the records to map signs and other points on the OSM. I make the records for myself primarily.

This is one of my vertical records: https://openstreetcam.org/details/1274477/617/track-info It looks nice for me: image

This is the first and the last horizontal track I made: https://openstreetcam.org/details/1320927/2/track-info Look similar, but hood takes more space due to horizontal mode. image

Yes, my monitors are also in portrait mode, and I'm not going to rotate them.

bogdans-telenav commented 5 years ago

@532910, We will fix this since it is a bug.

My screen is locked to portrait. When I in the bed, I hold the phone in the portrait mode relative to me, but it's in the landscape relative to the horizon. The app ignores this lock and draws based on the acceleration sensor.

I reviewed your photos and you're phots have an aspect ratio of 1:1 (most of the photos have h:w were h different form w and h < w in landscape and vice versa in portrait). For your specific device there is no improvement in image quality i will give you that.

I will close this issue as soon as the bug is fixed. Thanks!

532910 commented 5 years ago

So "We will fix this since it is a bug." or "added the wontfix"?

bogdans-telenav commented 5 years ago

We will not change the behavior of the recording -> that part we won't fix -> tags: "wontfix" & "by design" We will fix the bug in the review screen -> tag: "bug"