search

kartaview / upload-scripts

Uploader tools for KartaView
MIT License
59 stars 30 forks source link

Switch to OAuth 2 #139

Closed danieldegroot2 closed 1 week ago

danieldegroot2 commented 8 months ago

Switch to OAuth 2 from HTTP Basic Auth and OAuth 1.0a. They are being deprecated. See https://github.com/openstreetmap/operations/issues/867

cc: @GRABOSM

trigpoint commented 4 months ago

OAuth has now been depreciated meaning it is no longer possible to use these scripts to contribute to Kartaview.

This needs urgent attention.

mapdevsaikat commented 4 months ago

Hello @danieldegroot2 and @trigpoint ,

Thank you for addressing the issue. Our Engineering Team is looking into it, we will post updates here.

davebulow commented 2 weeks ago

Hello! Just wondering if there's any progress on this as I'm unable to upload anything at present. Many thanks in advance. Looking forward to being able to use this tool to contribute more extensively to Kartaview in the near future. Or at least I assume that's the reason it won't upload despite me authorising Kartaview to access my OSM account?

C:\Users\daveb\Desktop\upload-scripts-master\upload-scripts-master>python osc_tools.py upload -p "C:\Users\daveb\Desktop\testupload"
Searching for sequences...
    Found sequence at path C:\Users\daveb\Desktop\testupload. Sequence type Exif-Photo.
Search completed.

Starting to upload 1 sequences...

For login go to this URL in your browser:
https://www.openstreetmap.org/oauth/authorize?oauth_token=qP5Ugf6UTc49lDxt2AGWxoVj3nqcORWsmQFuLYge
Login and grant access then press ENTER

An error occurred.
This error can occur when you did not log in your browser. Please make sure to follow the next steps to retry.

For login go to this URL in your browser:
https://www.openstreetmap.org/oauth/authorize?oauth_token=ivUKEaLdpQWnUjPYEdGPvIqX88BDb0nWgOJ1OeQ6
Login and grant access then press ENTER

Error message: Token request failed with code 401, response was ''.
Please report this issue with the error messagehttps://github.com/openstreetcam/upload-scripts

C:\Users\daveb\Desktop\upload-scripts-master\upload-scripts-master>
salabogdan commented 1 week ago

fixed by

davebulow commented 1 week ago

@salabogdan Thank you so much! I just tested it and can confirm this now works. (Command line on Windows 11 in my case). Really appreciate you doing this!

GRABOSM commented 1 week ago

Hello @danieldegroot2 and @trigpoint,

The OAuth issue is fixed now, please feel free to give it a try. Thank you @salabogdan!

davebulow commented 1 week ago

@GRABOSM Indeed, I've been testing it and the upload function is working very well! Thank you! (Hopefully the new issue where no uploads are processing will be fixed soon too. Then it'll be even better 😄. Who can I contact about it? No Kartaview uploads have been processed for the last 7 days) I've tried emailing Gab/Kartaview but heard nothing. I can't post about it here because it's unrelated to the upload scripts.