search

kartaview / upload-scripts

Uploader tools for KartaView
MIT License
61 stars 30 forks source link

Hidden temporary file causes upload_photos_by_exif ordering by timestamp to fail #20

Closed ToeBee closed 6 years ago

ToeBee commented 7 years ago

I just uploaded this sequence: http://openstreetview.com/details/27578/0

Notice that the picture order is completely wrong. Since the ordering by EXIF time stamp was added to the upload script I was surprised by this. But it turns out I had a file named .GOPR1874.JPG.DRuZYO in the directory. It was zero bytes in size and looks like something left over from either an interrupted rsync or maybe a batch imagemagick job. But it was enough to cause the exist_timestamp variable on line 359 to be set to false which then disabled EXIF sorting on the whole batch. This caused sorting to fall back to mtime which is completely jumbled up for some reason in this directory.

After I deleted this file, the sequence uploaded in the correct order here: http://openstreetview.com/details/27580/0

I'm thinking the upload script should either ignore hidden files (granted, "hidden" files on a unix system is just a naming convention...) or maybe only upload files with .JPG at the end. Or both?

bogdan-racasan commented 7 years ago

Thanks for reporting. I will fix this bug as you recommend by upload only .jpg files 👍

ToeBee commented 6 years ago

I'm pretty sure this was fixed a while ago. Closing the issue.