kartaview / upload-scripts

Uploader tools for KartaView
MIT License
61 stars 30 forks source link

upload script shuffles images #22

Closed zdila closed 5 years ago

zdila commented 7 years ago

Upload script uses DateTimeOriginal to order files. If this exif field is missing, it shuffles the files. Problem is also if more files have the same value of DateTimeOriginal because script doesn't consider SubSecTimeOriginal.

Script could also consider using GPSTimeStamp and GPSDateStamp fields if above are missing.

mprins commented 7 years ago

eg. http://www.openstreetcam.org/details/165078/114

bogdan-racasan commented 6 years ago

@mprins This problem persists? Thanks for improving osm

mprins commented 6 years ago

it does not seem to upload at all now:

(openstreetcam_upload-scripts) XXXXXXXXXXXXXXXXXX/openstreetcam_upload-scripts/upload_photos_by_exif$ python upload_exif.py -p /XXXXXXXXX/2017_04_26_14_40_37_931/
Found 1487 pictures to upload
100%|██████████████████████████████████████████████████████████████████████████████ 1489/1489 remaining:00:00  elapsed:00:00
Request/Response fail
Retry attempt : 0
Request/Response fail
Retry attempt : 0
Retry attempt : 1
Request/Response fail
Retry attempt : 0
Request/Response fail
Retry attempt : 0
Retry attempt : 1
Retry attempt : 2
...

will try again later

bogdan-racasan commented 6 years ago

do you still have this problem??

mprins commented 6 years ago

I tried again and no luck uploading at all.. sit seems to hang for a while at

Retry attempt : 248
Retry attempt : 247
Retry attempt : 246
Retry attempt : 249
Retry attempt : 249
Retry attempt : 248
Retry attempt : 250
Retry attempt : 247
Retry attempt : 250
Retry attempt : 249

and than again at some 120 or so higher, and again and again etc.., basically exhausting sockets and then waiting. There is no feedback as to what is going on.. and no indication when the script will finish if at all

Retry attempt : 1694
Retry attempt : 1727
Retry attempt : 1593
Retry attempt : 1572
Retry attempt : 1695
Retry attempt : 1728
Retry attempt : 1594
Retry attempt : 1573
Retry attempt : 1696
Retry attempt : 1729
Retry attempt : 1595
Retry attempt : 1574
Retry attempt : 1697

So the original problem does no longer occur because uploading fails at all

mprins commented 6 years ago

I tried the docker command with limited succes:

docker run -it --rm -v /mnt/XXXXXXX/2017_04_26_14_40_37_931/:/data openstreetcam/upload_photos_by_exif

which seemed to start uploading OK (after removing the left behind count and seq id file) but checking the website things are still messed up for this sequence (http://www.openstreetcam.org/details/930585/0)

mprins commented 6 years ago

and a smalll one with images that have direction info as well: http://www.openstreetcam.org/details/930591/0

note to self: 2017_04_26_11_16_19_768

bogdan-racasan commented 6 years ago

@mprins Sorry about this. Can you provide some images? Thanks!!!

mprins commented 6 years ago

@bogdan-telenav I've uploaded the images of that last sequence to WeTransfer: https://we.tl/2TDKx3ZkQ3

bogdans-telenav commented 5 years ago

We made major changes to the previous version of the script and we now take into consideration GPS time stamp, so this is most likely fixed. If you find any other problem please create a new issue.

mishari commented 5 years ago

0000001 0000002 0000003 0000004 0000005 0000006 0000007 0000008 0000009 OSC_logs.log