search

kartaview / upload-scripts

Uploader tools for KartaView
MIT License
61 stars 30 forks source link

script exit code when having failed uploads #24

Closed Skippern closed 2 years ago

Skippern commented 7 years ago

The scripts are exiting with status 0 on completion, even when uploads have failed. This makes it complicated to run scripts, or verify long sequences. If sequence have not been completely uploaded, the script should return any number but 0

bogdan-racasan commented 7 years ago

Hmmm ... a log file could be added also you can look into some files like: index_write so you can know what was uploaded or where was stoped. Also the script use this file to know were to begin if there was a problem or the script was stoped

Skippern commented 7 years ago

but it would be rather easy for you to add sys.exit(1) if the upload isn't completed, that way I wouldn't need to do multiple checks, though I guess if [ 'ls *jpg | wc -l' -gt 'cat index_write.txt | wc -l' ] or something along that line could work for now.

bogdan-racasan commented 7 years ago

👍 Thanks for this idea. In next commits i would add this.

Skippern commented 7 years ago

I'll wait your solution instead of altering the script. Thanks

bogdan-racasan commented 6 years ago

@Skippern Can you check now the scripts? I've made some improvements and any feedback is welcomed.

Skippern commented 6 years ago

@bogdan-telenav I have no time to record at the moment, I will look at having some new traces recorded end of this month, and try the script again.

bogdan-racasan commented 6 years ago

@Skippern Not a problem. Thanks again for everything.

bogdans-telenav commented 5 years ago

We made major changes to the previous scripts. So this must be re-fixed for the current version.

salabogdan commented 2 years ago

This issue is no longer active i will close it.