kartevonmorgen / kartevonmorgen.ts

Mapping-Frontend to find and add sustainable Organisations (Initiatives, Companies) and Events on Kartevonmorgen.org / MapofTomorrow.org
https://kartevonmorgen.org/
GNU General Public License v3.0
11 stars 12 forks source link

[BUG] orgTag should also define the preview-list #205

Closed wellemut closed 5 months ago

wellemut commented 5 months ago

Bug

Unaproved changes should never be visible on a map with activated orgTag-mode!

This map has the orgTag mode activated (defined by &orgTag=hessenwillsmessen in the URL) https://www.kartevonmorgen.org/m/hessenwillsmessen?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test

The Test-Entry and the word "Test" in the description of the backery got never approved in the clearance-center. But still it is visibel: grafik

When you click on the entry, the detailed view is correct as it shows no "Test" in the description: https://www.kartevonmorgen.org/m/hessenwillsmessen/e/3fada349903f4d129f6cd918f67094c9?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test grafik

Opening the test entry does not show anything, which is basically correct, because it is not allowed to show someting. But the entry should not displayed on the map as a dot and not in the list, so no user should be able to click on it. grafik

Expected behavior

On the old Frontend you see the correct behavior: The test entry is not visible at all and the "Test" in the backery descritpion does not appear: https://v0.kartevonmorgen.org/#/?center=50.616,8.262&zoom=11.00&search=%23hessenwillsmessen%20test&fixedTags=hessenwillsmessen&orgTag=hessenwillsmessen&dropdowns=hessenwillsmessen grafik

Obviously, you can not open the Test entry, as it is not visible, so no empty white page!

Technical Background

Additional context This function on the new frontend is highly relvant for HLNUG. They use the clearance-Center to moderate their map, which is embedded on a govermental page. So no unapproved changes on the map should every be visible on a official public website.

navid-kalaei commented 5 months ago

fixed and deployed on the dev domain. please test. @wellemut

wellemut commented 5 months ago

@navid-kalaei thank you. But on https://dev.kartevonmorgen.org/m/hessenwillsmessen?c=50.5517%2C9.6752&z=16.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=gray

The problem still exists. This "Test" should not be visible in the result list Screenshot_20240326-204435~2.png

The detailed view is correctly filtering for an approved version of the entry Screenshot_20240326-204439~3.png

navid-kalaei commented 5 months ago

@wellemut I'm confused, which format is correct: orgTag or org_tag? I implemented the org_tag should i change it/

wellemut commented 5 months ago

Perfect @navid-kalaei It is working now https://dev.kartevonmorgen.org/m/hessenwillsmessen?c=50.5493%2C9.6724&z=16.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=gray

Please create the pull request for @alex0107

navid-kalaei commented 5 months ago

@wellemut @alex0107 created a new release of v1.2.1 https://github.com/kartevonmorgen/kartevonmorgen.ts/releases/tag/1.2.1