Avoid white screen after adding new entry on orgtag-view

wellemut commented 4 months ago

Problem

You end up on a white screen without any Warning or Button, after you have added a new entry on an orgTag-View. (Because the orgTags stops the new entry to be loaded, as there is no approved version availiable) grafik https://www.kartevonmorgen.org/m/hessenwillsmessen/e/496f510a373c4f728134a69cfb1e7eac?c=50.5220%2C9.5423&z=13.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=

To Reproduce Steps to reproduce the behavior:

Go to https://www.kartevonmorgen.org/m/hessenwillsmessen?c=50.5184%2C9.5452&z=13.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen (Important that URL contains orgTag=hessenwillsmessen)
Click on "Add new Entry"
Fill out all nessesary fields and click "Save"
Error: You end up on a white sidebar and it feels like it has gone wrong.

The Backend sends an empty Json file for the newly created entry: https://api.ofdb.io/v0/entries/496f510a373c4f728134a69cfb1e7eac?org_tag=hessenwillsmessen

Expected behavior**

[ ] Whatever I open, whatever is loaded or not loaded, the Back-Button (1) should allways be visible on the entry detail page!!!

Two Options

[ ] A. I see a message "Thank you for submitting a new entry. It's waiting for approval"

grafik

Advantage: The user knows, that his entry need approval and that he might not find it agai
Disadvantage: The user cant see his result and can not improve it instantly

[ ] B. Always when clicking "Save" the orgTag is removed from the API which get send to the backend.

https://api.ofdb.io/v0/entries/496f510a373c4f728134a69cfb1e7eac ~~?org_tag=hessenwillsmessen~~ Than the View for the creator is always the same like on maps without orgTag-View. But dont forget to add the ?org_tag=hessenwillsmessen as soon as you leave the entry detail view

Advantage: The user can see the result, his new entry and his changes and can add further improvements directly.
Disadvantage: When he leaves his new entry, he will never find it again or not his changes and he does not no why...

wellemut commented 4 months ago

@navid-kalaei Do you prefer Option A or B for the solution of this bug?

navid-kalaei commented 2 months ago

I show a message that the entry does not exist or requires approval kvm-org tag

navid-kalaei commented 2 months ago

fixed on commit a3fde95812a2ce079a3e62c97c534a9481396c69

wellemut commented 2 months ago

It's working amazingly great, till the new info screen https://dev.kartevonmorgen.org/m/hessenwillsmessen/e/7950653a151c4a9f863de4d7b8c21999?c=50.7922%2C8.9115&z=14.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=gray

[ ] but if I click on the button "back to search results" nothing happens at all!

@navid-kalaei

[ ] can I find the new strings in the language file to translate it?
[ ] why is it not possible to edit existing entries. I get such a blocking error notification at the top:

Is it something which you changed? Or an old backend feature?

wellemut commented 1 month ago

@navid-kalaei could you please fix the button, so that it really brings you back to the search results. Currently nothing happens.

navid-kalaei commented 1 week ago

I added the click event on the back to the search result button on commit 2de858c22da56025d0b7e5e4e6a7d0cfd6e5dba3
the translation is here: https://github.com/kartevonmorgen/kartevonmorgen.ts/blob/d6b70b0eee29d3a5a1fdf6f5fdf4efdd9f5a2402/locales/en/map.json#L377
I believe the error comes from the back end because I don't have such a string The tag is owned by an organization on my side @wellemut

kartevonmorgen / kartevonmorgen.ts