search

kartevonmorgen / kartevonmorgen.ts

Mapping-Frontend to find and add sustainable Organisations (Initiatives, Companies) and Events on Kartevonmorgen.org / MapofTomorrow.org
https://kartevonmorgen.org/
GNU General Public License v3.0
11 stars 12 forks source link

[BUG] `orgTag` and `orgtag` currently fail as it is case sensitive #216

Open timmwille opened 2 months ago

timmwille commented 2 months ago

Problem

A clear and concise description of the bug.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a link with &tag=xyz&orgtag=xyz
  2. check for accepted locations only
  3. realise it is all the same as without orgtag
  4. Look for a mistake.

Expected behavior

Outcome of orgTag and orgtag is easily mistaken if one does currently not apply the correct spelling. orgTag and orgtag could be the same result.

Solution

Additional context I think it is easy to solve via case insensitivity for the writing of orgTag It took me a long time to figure this out, but can easily happen.

wellemut commented 2 months ago

Thanks for this report. Good point but low prio in my eyes The orgTag feature is no enduser feature, so target group only 20 admins that have technical knowledge, bug tolerance and in 90% of them they get a close help and guidance by experienced mappers...

timmwille commented 1 month ago

it actually is a bit confusing to have "orgTag" and "org_tag" in API and URL options plus naturally one tends to write "orgtag" as multiple issue titles proof. - If it is not too much of a pain it would really help to synch this or make agnostic.

It almost stopped us from implementing the map in the way we planned it.

edit: actually there is also OrgTag :D

https://github.com/search?q=repo%3Akartevonmorgen%2Fkartevonmorgen.ts%20orgtag&type=code

wellemut commented 1 month ago

@flosse wie kann man die API-Commans nicht mehr case sensitiv machen? Das führt wohl zu langen fehlersuchen. bzw. wie können wir hier aliasse definieren?

Der Variablen-Namen sollste nicht case sensitiv sein der Wert darf aber case sensitiv sein.