search

kartevonmorgen / kartevonmorgen.ts

Mapping-Frontend to find and add sustainable Organisations (Initiatives, Companies) and Events on Kartevonmorgen.org / MapofTomorrow.org
https://kartevonmorgen.org/
GNU General Public License v3.0
11 stars 12 forks source link

Iframe Generator Button got lost #226

Open wellemut opened 3 weeks ago

wellemut commented 3 weeks ago

Problem

The Button "iframe" got lost in the sharing menu grafik

instead there is the subscribe-button, which endpoint is not working yet.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the map https://www.kartevonmorgen.org/m/kvm?c=50.8198%2C5.6030&z=6.00
  2. Click on "share" down right
  3. you cant find "share iframe code"

Expected behavior

In dependently, if the "subscribe" button is activ or not, the "Embedd as ifrmes" button should never disappear Image

Additional context I guess, the problem came with the last release, when some dependencies were "rolled back" https://github.com/kartevonmorgen/kartevonmorgen.ts/compare/v1.2.7...v1.2.8

Definiton of Done

wellemut commented 3 weeks ago

@navid-kalaei please checkout, what could be the reason and estimate a story point number, how easy we could fix it?...

navid-kalaei commented 2 weeks ago

@wellemut it was my error during the development. I have made the subscription almost ready and before pushing to the production level I accidentally disable the sharing button disable instead. I made it back on commit 798439ba608c6de9fffdfb1e3cbeee16da62d9ae