search

kartevonmorgen / kartevonmorgen

This is the Alpha version (v0) of Karte von morgen. Please contribute to our new project in TypeScript (v1) https://github.com/kartevonmorgen/kartevonmorgenssr
https://kartevonmorgen.org
GNU Affero General Public License v3.0
60 stars 24 forks source link

Check for duplicate entries on creation #714

Open paviro opened 4 years ago

paviro commented 4 years ago

Problem

I have already found a few duplicates and nearly created one myself. If a website embeds a map with a specific tag, an entity might not be shown and created again.

Solution

We should therefore check if something with the same address or name exists already in a certain radius and ask the user if they are the same.

1. Its a change in the entries-formular

  1. Location
  2. Title 3. New: List of duplicates (or they open in a popup...)
  3. Categories
  4. Tags
  5. All other optional contact details and links...

grafik

2. Use the Duplicate API

Use this API https://app.swaggerhub.com/apis/Kartevonmorgen/open-fair_db_api/0.10.3#/Search/post_search_duplicates you will get back all APIs that are possible duplicats

Show duplicates in a list.

This is an example of a duplicate warning on Discourse (https://discuss.m4h.network/) grafik

Advanced Issues for the far future: In case #712 gets implemented we should also check if the entity already exists in general and if the new one should be added as a branch.

paviro commented 4 years ago

Relevant backend issues: https://github.com/kartevonmorgen/openfairdb/issues/254 https://github.com/kartevonmorgen/openfairdb/issues/257

iJoise commented 3 years ago

I take this task

AndrusovN commented 3 years ago

2021-08-05_23-20-42 Before we choose any category there is only category selection field. So it would be very strange if after selecting it will move down to the 4-th position My suggestion would be to leave it (category selection field) where it is now.

AndrusovN commented 3 years ago

When sending request to server there appears CORS error because we send request from incorrect origin (localhost). Where the production version (v1) is deployed now? Maybe the problem will be solved if we deploy NEXT on some server

iJoise commented 3 years ago

the task is ready PR: https://github.com/kartevonmorgen/kartevonmorgen-v1/pull/23

wellemut commented 3 years ago

@navid-kalaei is this feature already running somewhere? I redirected kirill.kartevonmorgen.org to your server, in case you need a domain for testing.

thank you very much!

iJoise commented 3 years ago

@wellemut After making the changes that are mentioned here https://github.com/kartevonmorgen/openfairdb/issues/363 I'm ready to add the necessary changes as originally intended, make some test entries and push them into your branch, if you don't mind

wellemut commented 3 years ago

great, thank you very much!

wellemut commented 3 years ago

Yes, please push a pull-requeste

@navid-kalaei can deploy it here http://kirill.kartevonmorgen.org/