Open flosse opened 4 years ago
@navid-kalaei FYI: #259 would be your point to start with a more complex notification system.
Thank you so much @flosse. I'll follow the PR #259 and it's following commits :pray: :tada:
Beautiful new subscription popup on the mapa project (Belarus) https://mapa.falanster.by/#map Here is my feedback:
even for me I needed to think a while till I knew, what I have to select to subscribe the right thing. The Radio-Button with three options seems to me just confusing. Also: What happens, if the user chooses "Initiative" but no inititiative is selected? What if he chooses TagsGeo but no tag is used? Put away theses buttons and let just subscrieb to what ever is visible on the map behind the popup.
Cancel-Button can be removed as well.
Here is a schema how it should be build in the future.
The preliminary draft of the Subscriptions API can be found here: https://github.com/magdaddy/kvm-welcome-email/blob/subscription/openapi.yaml
Subscriptions API
The preliminary draft of the Subscriptions API is in the openapi.yaml file. You can render the API documentation e.g. with the swagger editor:
go to https://editor.swagger.io
go to File -> import URL
enter https://raw.githubusercontent.com/magdaddy/kvm-welcome-email/subscription/openapi.yaml
The API Endpoint is now availiable here: https://app.swaggerhub.com/apis/Kartevonmorgen/subscriptions-api/0.0.0#/Subscriptions/post_subscribe
@flosse Auf dem neuen Frontend ist kann man sich aktuell weder einloggen, noch einen ausschnitt abonnieren.
Das abonniren soll aber sowieso ohne login viel einfacher werden. Daher braucht das neue Frontend auch kein login. könntest du das schonmal mitdenken, wenn du dir Magnus Update-Tool anschaust, wie dort ein direktes abonnieren hinterlegt werden kann. (https://github.com/kartevonmorgen/openfairdb/issues/333)
D.h. vermutlich gibt es nicht nur ein umbau wie mails an Auschnitt-Abonnementen verschickt werden, sondern auch, wie diese Mailadressen mit bbox erfasst und gespeichert werden...
Board for Subscriptions: https://github.com/orgs/kartevonmorgen/projects/4?fullscreen=true
Prerequisites
Target Group
Only a few power users will use the subscriptions, but those are the users, that improve the quality. So If we empower them, we improve the map qualitiy to all users, thats why it is a feature für all users.
Problem
Solution
Just allow to subscribe to any search and map view
[ ] Rather usefull i think would be the option to subscribe to hashtags. So on the page where you choose the area, you also have the searchline to put in some keywords and tags. Especially if there are coming the events. But also like this it would help the theme-pilots to subscribe to alle csa-projects in the world. but only csa.
[ ] Subscribe to single entries, also while editing. https://github.com/kartevonmorgen/kartevonmorgen/issues/635
[ ] We should definitly include Positive Impact Ratings in the notification-System. https://github.com/kartevonmorgen/openfairdb/issues/94 (More imprtant than the question, if an entry is on the map, is the question, how good it is rated. )
[ ] Notify users at maximum once a day: Only send notification Mail after there was no editing for at least 30 min. Otherwise we spam users too much with notifications if we send it evrey minute and someone is just trying how the map works... Maybe even just once a day https://github.com/kartevonmorgen/openfairdb/issues/44
[ ] Unsybscribe link in every notification-mail https://github.com/kartevonmorgen/openfairdb/issues/45 . Each subscription is saved so you can delete every single subscription with an link in the mail.
Fazit
Kartenausschnitt abonnieren
-thing doesn't really fit undershare
, I'm rather "sharing" it with myself, and we might have more features in the future that don't really fit in these two categories and if we put them there anyway it gets confusing for users.