search

karthik / testdat

A package to run unit tests on tabular data
142 stars 20 forks source link

Add support to check spatial data #19

Closed karthik closed 9 years ago

karthik commented 10 years ago

If there are columns named latitude and longitude, we should check to see that impossible values down show up.

lat goes from 0° to (+/–)90°. long goes 0° to (+/–)180°.

karthik commented 10 years ago

good point @jhollist

Ironholds commented 9 years ago

Would also recommend "lat" and "lon(g)" be treated as analogous. I'll try to find the time to patch this weekend.

karthik commented 9 years ago

awesome, thank you.

Ironholds commented 9 years ago

Wait: that seems to [https://github.com/ropensci/testdat/blob/master/R/test_coords.R](already exist). What am I missing? Nice integration to check names and scan a particular column?

karthik commented 9 years ago

Sorry, totally forgot. Thanks for checking. I need to get back to this package and get the first iteration ready for CRAN and make it work with ensurer which has some functionality that we have been trying to implement. Closing (sorry for the duplicate Oliver).

Ironholds commented 9 years ago

NP!

Ironholds commented 9 years ago

I'll take the opportunity to go through other bugs and see if there's anything outdated/that I can help with, if you're hoping for a release soon :)

karthik commented 9 years ago

Let me do a review today and post a few issues. I'll tag you where you can help!

Ironholds commented 9 years ago

KK!