Upcoming updates - Githubissues

karthik / wesanderson

A Wes Anderson color palette for R

Other

1.94k stars 147 forks source link

Upcoming updates #3

Open karthik opened 10 years ago

karthik commented 10 years ago

Based on discussions with Hadley, I'm going to rework the package to stop mimicking the same style as RColorBrewer.

[ ] I'll just add S3 methods to just plot any palette
[ ] Avoid using get
[ ] Add a whole slew of new palettes I've been painstakingly assembling (no longer from the tumblr)

If anyone has other suggestions, please add here. I'll leave this version as-is for RColorBrewer fans and bump up to version 2.

jhollist commented 10 years ago

Saw this after I sent my pull request.

Hmmm, may not make sense to add mine in given you have plans for new palettes...

karthik commented 10 years ago

Thanks Jeff! Ah, no worries. I'll review this PR next week and get back to you.

jhollist commented 10 years ago

Sounds good.

On Fri, Jul 25, 2014 at 12:31 PM, Karthik Ram notifications@github.com wrote:

Thanks Jeff! Ah, no worries. I'll review this PR next week and get back to you.

— Reply to this email directly or view it on GitHub https://github.com/karthik/wesanderson/issues/3#issuecomment-50172997.

Jeff W. Hollister email: jeff.w.hollister@gmail.com google voice: 401 326 2531 cell: 401 556 4087

hadley commented 9 years ago

https://github.com/hadley/wesanderson/tree/palette-list implements the first two - happy to turn it into a pull request

karthik commented 9 years ago

@hadley I looked this over and it would be great to have as a PR. Please send along when you find some time. Thanks!