karthikv / my-style

My Style is a Google Chrome extension that allows you to insert custom CSS into pages, immediately see the visual results, and have that CSS persist for future visits.
MIT License
344 stars 35 forks source link

File-based Storage #6

Open zackbloom opened 11 years ago

zackbloom commented 11 years ago

First pass at using the file writer / reader apis. Should properly migrate localStorage based styles, but as of now, seems to require a permission acceptance.

karthikv commented 11 years ago

Thanks for taking care of the file system integration! Apologies for the delayed response.

I made a few comments on your code, but once those are resolved, I'd love to get this integrated. Excuse me if my comments seem too pedantic, but I think code is only good insofar as it's consistent. Feel free to argue with my points if you feel differently.

zackbloom commented 11 years ago

I believe I made all the changes. It was interesting getting a chance to work with someone else's coding style.