search

karthink / consult-dir

Insert paths into the minibuffer prompt in Emacs
GNU General Public License v3.0
160 stars 9 forks source link

Add custom for enabling completion candidate sorting #36

Closed svaante closed 6 months ago

svaante commented 6 months ago

Hey great package!

I find completion sorting extremely useful, I don't know the reasons for it being disabled but having it behind an custom seams like an reasonable option.

karthink commented 6 months ago

@svaante Thanks for the PR!

Adding support for sorting is fine, but I plan to submit this package to GNU ELPA very soon, so contributions require copyright assignment to the FSF. Have you done that? They're okay making an exception for a 2-line change (like here), but not if your total contribution to ELPA or Emacs exceeds around 15 lines.

svaante commented 6 months ago

Hey! I have done my copyright assignment to the FSF. So from that perspective we are good to go!

karthink commented 6 months ago

All good then, cheers!