search

karthink / elfeed-tube

Youtube integration for Elfeed, the feed reader for Emacs
The Unlicense
241 stars 11 forks source link

Fix duration typo #1

Closed danilevy1212 closed 2 years ago

danilevy1212 commented 2 years ago

Hey! This little error was preventing me from using this package, figured I would share with upstream :). Great package!

karthink commented 2 years ago

Dang, missed that. Thanks for catching it! Cheers @danilevy1212.

karthink commented 2 years ago

@danilevy1212 From your PR I'm assuming you're saving video data fetched by elfeed-tube to your elfeed-db. Can you keep an eye out for elfeed-tube data disappearing from the elfeed db in subsequent Emacs sessions? I'm not able to test the persistence of data on disk successfully and think elfeed-db's garbage collector might be throwing away some stuff fetched by elfeed-tube.

danilevy1212 commented 2 years ago

@karthink Yeah, I have (setq elfeed-tube-auto-save-p t). I really haven't been paying attention if it's actually persisting or not, I will from now on.