search

karthink / gptel

A simple LLM client for Emacs
GNU General Public License v3.0
1.03k stars 111 forks source link

Replace window-width with frame-width #301

Closed RNAer closed 1 month ago

RNAer commented 2 months ago

To avoid truncate of the text for the vertically split window like this:

Screenshot 2024-05-01 at 12 29 56 PM
karthink commented 1 month ago

Thanks for the PR!

Actually neither window-width nor frame-width are correct here, since the width of the transient window depends on the value of transient-display-buffer-action. For example, transient menus appear below the active window for me, which means they are only as wide as the window, not the frame:

2024-05-02-113244_1427x744_scrot

So a better fix is needed.

RNAer commented 1 month ago

Thanks! good to learn a new thing transient-display-buffer-action. org-roam has a similar problem with org-roam-node-find cmd, even though it is minibuffer not transient.

karthink commented 1 month ago

Created an issue so this PR can be closed.