search

karthink / gptel

A simple LLM client for Emacs
GNU General Public License v3.0
1.14k stars 119 forks source link

Typo in defining the gtpel minor mode #35

Closed ink-pot-monkey closed 1 year ago

ink-pot-monkey commented 1 year ago

Just a minor typo which doesn't have any effect as the default for :global is the same as setting it to nil but spotted during a curiosity dive. Didn't seem significant enough to warrant a PR

https://github.com/karthink/gptel/blob/e2afe5000e507c4e8f06732cf788da09c76869b9/gptel.el#L235

karthink commented 1 year ago

@thomassdk thanks. Since you mentioned "curiosity dive": If you're in an exploratory mood, could you check out the streaming branch of the repo, set gptel-playback to t and try using the package? I've got real-time streaming working but I'm wondering if it works for anyone else yet.

ink-pot-monkey commented 1 year ago

just checked that branch out and its working smoothly for me :)

karthink commented 1 year ago

Thanks, I pushed the streaming replies feature to master.

I'll fix the :global nil line soon. At some point gptel-mode was set to be :global t and I didn't clean things up after the design changed.

karthink commented 1 year ago

Fixed.