search

karthink / gptel

A simple LLM client for Emacs
GNU General Public License v3.0
1.14k stars 119 forks source link

Give pulse-momentary-highlight-region a fallback END argument #38

Closed twashing closed 1 year ago

twashing commented 1 year ago

If there is an error in the response, instead of giving the response error, it's giving an error of pulse-momentary-highlight-region.

karthink commented 1 year ago

EDIT: I rewrote the process sentinel to better handle errors, so this fix should not be needed any more. Thanks for figuring out the problem!

Original response below:

Thanks, I've had trouble generating erroneous responses for testing.

When there's an error or no response, it shouldn't pulse anything at all. Could you change it instead to

(when tracking-marker
   (pulse-momentary-highlight-region ...))
twashing commented 1 year ago

EDIT: I rewrote the process sentinel to better handle errors, so this fix should not be needed any more. Thanks for figuring out the problem!

Ah ok 👍🏿 I've pushed a commit of your suggestion, in case you need it. Thanks!