search

karthink / gptel

A simple LLM client for Emacs
GNU General Public License v3.0
1.64k stars 151 forks source link

bug fix in Ollama backend: options-plist -> prompts-plit #472

Closed andrewdea closed 2 weeks ago

andrewdea commented 2 weeks ago

hey thanks for working on this package, it's amazing 💜

latest commit introduced a small bug in gptel-ollama.el: code was trying to modify options-plist without having setting it, resulting in "setq: Symbol’s value as variable is void: options-plist".

Here's my fix: if I'm understanding things right, options-plist is not used anymore, so we just put the values directly into prompts-plist

karthink commented 2 weeks ago

Thank you for catching that! That's what I get for turning off the linter. Unfortunately your fix won't work since temperature, max_tokens etc need to be one level deeper, inside an :options field. I just "fixed" it -- I was in the middle of working on the code already -- but by punting a potential issue into the future (the commit message explains).