karthink / gptel

A simple LLM client for Emacs
GNU General Public License v3.0
1.06k stars 116 forks source link

Should we quit `gptel-system-prompt` after select? #95

Closed tshu-w closed 11 months ago

tshu-w commented 11 months ago

I prefer to quit gptel-system-prompt after select a directive

I'd like to know what you think.

karthink commented 11 months ago

My idea when making this persist was that you can't preview the directive before you choose it, so the user might want to press (in this example) p, d, c, w etc and read the "current directive" header before finalizing their choice: 2023-07-30-123230_762x215_scrot

That said, the current directive is shown here in the main gptel-menu as well: 2023-07-30-123426_767x276_scrot

So what you suggest makes sense too. It would take two keys now -- hp, hd, hc, hw etc -- to preview directives. Let me try your PR for a couple of days and see if it works better this way.

tshu-w commented 11 months ago
Screenshot 2023-07-31 at 10 48 39

And the directive will show in the echo area after selection too. For me, I'll be pretty sure of each selection and there are rarely multiple switches, so I want to avoid redundant exits press.

karthink commented 11 months ago

It works well, thank you for the PR.