search

karthink / project-x

Ehancements to Emacs' built in project library.
74 stars 5 forks source link

project-x on MEPLA #5

Open manufactory opened 2 years ago

manufactory commented 2 years ago

Hello,

Is there any specific reason why project-x is not available on MEPLA? If you have nothing against it, I'd be happy to create recipe and open a PR to get it added :)

karthink commented 2 years ago

Hey @manufactory,

I was initially hesitant to submit this to MELPA since project.el is being actively developed and thus project-x might break often. However there have been no breaking changes since I wrote it, so it might be a good idea to do so now. I don't have the time for this at the moment, but feel free to submit it to MELPA if you're interested. The code will need to be linted to pass the MELPA review, I can make you a co-author if you're okay with doing that.

What do you think?

EDIT: You can also submit the linted version as a PR I guess.

manufactory commented 2 years ago

Hey,

Thanks! I ran all the linters suggested by MELPA and they found no issues.

When going through the code, the only thing that I noticed is that (project-root) can be replaced by (project-root) provided by project.el.

I found an issue when playing around: Projects (sometimes?) don't get recognized when there's a .project file in the main directory. My test case is quite simple: I created a directory, ~/tmp/project-x-test, containing two files and an empty .project file, invoked (project-x-mode) and the project directory is always my home directory, not ~/tmp/project-x-test. I'm also quite busy, but perhaps I find some time to look into that. It might just be the order in which packages or hooks are loaded. I'll keep you posted :)

kingcons commented 2 years ago

Any update on this? It would be lovely to see this package available publicly. I may be able to look into it in the next week or two if you're both busy. :)

manufactory commented 2 years ago

I'm currently to busy to work on this, so if @karthink is fine with it go ahead :)

karthink commented 2 years ago

A little held up at the moment, please feel free to submit it. 👍

On Sun, Jan 23, 2022, 11:42 AM Brit Butler @.***> wrote:

Any update on this? It would be lovely to see this package available publicly. I may be able to look into it in the next week or two if you're both busy. :)

— Reply to this email directly, view it on GitHub https://github.com/karthink/project-x/issues/5#issuecomment-1019553439, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBVOLC4QKNDPUDPKP7DXWTUXRKZNANCNFSM5ID5LBIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

trev-dev commented 1 year ago

I volunteer to submit it, @manufactory

karthink commented 1 year ago

@trev-dev Thanks. Before submission, it might be a good idea to update the package for Emacs 29, since the latest project.el has changed a bit. Nothing's broken in project-x (as best I can tell), but project.el has gained some of project-x's features, such as the ability to identify projects based on the existence of a special file in the root directory of the project.

I'm not on 29 yet so I haven't looked into it.

trev-dev commented 1 year ago

Funny, as the main reason I want project-x is for that project root feature. Emacs as a graphical program is a tad annoying to set up with the proper context.

Do you suspect that Emacs 29 will essentially deprecate project-x?

karthink commented 1 year ago

Do you suspect that Emacs 29 will essentially deprecate project-x?

project-x's other feature is to save and restore your project files and window configuration. project.el is not gaining this feature in Emacs 29, so project-x won't be deprecated. However there are many packages for saving and restoring state, such as tab-bookmark, burly, perspective, the built-in desktop.el etc. So I wouldn't say it's essential.

trev-dev commented 1 year ago

Apologies @karthink, but due to reasons not in your control I'm moving on from Emacs for now.

orazdow commented 7 months ago

This is a great package, I think it should go on melpa. I'm pretty new to emacs so I can't do a pr for it though unfortunately. Btw I'm on 29.2 and it works well.

karthink commented 7 months ago

This is a great package, I think it should go on melpa. I'm pretty new to emacs so I can't do a pr for it though unfortunately. Btw I'm on 29.2 and it works well.

If you're interested please go ahead, the only changes project-x will need are stylistic/linter warnings.