search

kartik-v / yii2-date-range

A Date Range Picker for Bootstrap useful for reports and filtering.
http://demos.krajee.com/date-range
Other
93 stars 81 forks source link

Depend on the 'yii\web\JqueryAsset' #73

Closed thiagotalma closed 8 years ago

thiagotalma commented 8 years ago

Fix an error ensuring that the js file is never included before jQuery.

(You need to evaluate this dependence in all of their assets that depend on jQuery)

samuelroxo commented 8 years ago

@kartik-v please, accept this request, this issue is becoming annoying.

kartik-v commented 8 years ago

Actually this may not entirely be the correct way to fix it... will try to check and update.

This is because the DateRangePickerAsset extends kartik\base\AssetBundle and the kartik\base\AssetBundle already depends on JqueryAsset.

So the depends property must not be overwritten...

samuelroxo commented 8 years ago

Thank you @kartik-v, you're the great.