search

kartik-v / yii2-export

A library to export server/db data in various formats (e.g. excel, html, pdf, csv etc.)
http://demos.krajee.com/export
Other
165 stars 126 forks source link

Update ExportMenu.php #289

Closed wakeup-now closed 5 years ago

wakeup-now commented 5 years ago

Fixes excel file with wrong / garbage encoding characters.

This is fixed by adding the following line line 798 + ob_end_clean();

ob_end_clean() is already in $this->clearOutputBuffers(); but calling it before $writer->save($file) instead of after fixes it.

Scope

This pull request includes a

Changes

The following changes were made (this change is also documented in the change log):

-

-

Related Issues

If this is related to an existing ticket, include a link to it as well.

kartik-v commented 5 years ago

This may not be needed. There is an enhancement subsequently and also an additional enhancement in #292 which should resolve this.