kartik-v / yii2-export

A library to export server/db data in various formats (e.g. excel, html, pdf, csv etc.)
http://demos.krajee.com/export
Other
165 stars 126 forks source link

Make _exportType and _triggerDownload properties protected #300

Closed Stern87 closed 4 years ago

Stern87 commented 5 years ago

Prerequisites

Steps to reproduce the issue

  1. Create class that extends 'kartik\export\ExportMenu' class
  2. Write 'run' function in order to override parent function
  3. Try to access $this->_exportType and $this->_triggerDownload properties

Expected behavior and actual behavior

When I follow those steps, I see that I can't access those properties since they are private.

I was expecting that they will be protected as all others.

Environment

Browsers

Operating System

Libraries

Isolating the problem

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.