search

kartik-v / yii2-export

A library to export server/db data in various formats (e.g. excel, html, pdf, csv etc.)
http://demos.krajee.com/export
Other
165 stars 126 forks source link

fix pagination for batchSize for page > 1 #301

Closed sheershoff closed 5 years ago

sheershoff commented 5 years ago

This commit addresses the following issue: If an example used with same dataProvider for ExportMenu and DataGrid and a user has navigated to page other than first, then first $page*$batchSize records would be skipped. Resetting the cloned pagination page to 0 worked for me.

Scope

This pull request includes a

Changes

The following changes were made (this change is also documented in the change log):

Related Issues

If this is related to an existing ticket, include a link to it as well.

onmotion commented 5 years ago

noticed your request after made my own #302 :) But I think in this case the first page will be requested twice.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.