[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] The issue still exists against the latest master branch of yii2-grid.
[x] This is not an usage question. I confirm having gone through and read the documentation and demos.
[x] This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
[x] I have attempted to find the simplest possible steps to reproduce the issue.
[ ] I have included a failing test as a pull request (Optional).
In EditableColumn.php, it says
if ($this->grid->pjax && empty($this->_editableOptions['pjaxContainerId'])) {
$this->_editableOptions['pjaxContainerId'] = $this->grid->pjaxSettings['options']['id'];
}
but the docs say:
The pjax container identifier is read via pjaxSettings['options']['id'] . You could override and manually set pjaxSettings['options']['id'] if you need your own pjax container identifier. If not set this defaults to: $grid->options['id'] . '-pjax'
So if you dont manually set pjaxSettings['options']['id'] and rely on the default of $grid->options['id'] . '-pjax', your pjaxContainerId will not be set automatically like it's doing for $this->grid->pjaxSettings['options']['id']
I think there should be a check for this should be included. Something like:
Then the people that rely in the default of $grid->options['id'] . '-pjax'; will automatically get their pjaxContainerId set just like they would if they specified $this->grid->pjaxSettings['options']['id']
Prerequisites
master
branch of yii2-grid.In
EditableColumn.php
, it saysbut the docs say:
So if you dont manually set
pjaxSettings['options']['id']
and rely on the default of$grid->options['id'] . '-pjax'
, yourpjaxContainerId
will not be set automatically like it's doing for$this->grid->pjaxSettings['options']['id']
I think there should be a check for this should be included. Something like:
Then the people that rely in the default of
$grid->options['id'] . '-pjax';
will automatically get theirpjaxContainerId
set just like they would if they specified$this->grid->pjaxSettings['options']['id']