Expand all twice in expandrow hangs the page - Githubissues

kartik-v / yii2-grid

Enhanced GridView with various utilities for Yii Framework 2.0

http://demos.krajee.com/grid

Other

556 stars 303 forks source link

Expand all twice in expandrow hangs the page #958

Closed Benn closed 4 years ago

Benn commented 4 years ago

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] The issue still exists against the latest master branch of yii2-grid.
[x] This is not an usage question. I confirm having gone through and read the documentation and demos.
[x] This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
[x] I have attempted to find the simplest possible steps to reproduce the issue.
[ ] I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

Go to the demo page (https://demos.krajee.com/grid-demo)
Click the + button to expand, and click the minus butto to colapse
Click the + button again

Expected behavior and actual behavior

When I follow those steps, I see the spinner which keeps turning, the rows do not expand. Single rows do still expand properly

I was expecting all rows to expand again.

Environment

Browsers

[x] Google Chrome
[ ] Mozilla Firefox
[ ] Internet Explorer
[ ] Safari

Operating System

[x] Windows
[ ] Mac OS X
[ ] Linux
[x] Mobile

Libraries

jQuery version: see demo
yii2-grid version: see demo

Isolating the problem

[x] This bug happens on the demos page
[ ] The bug happens consistently across all tested browsers
[ ] This bug happens when using yii2-grid without other plugins.

kartik-v commented 4 years ago

Fixed and resolved via above commit.