kartik-v / yii2-icons

Set of icon frameworks for easy use in Yii Framework 2.0
http://demos.krajee.com/icons
Other
72 stars 29 forks source link

Wrong flag-icon.css gets loaded, this file is changed to flag-icons.css in the latest components/flag-icon-css #53

Closed KevinVanH closed 3 months ago

KevinVanH commented 9 months ago

This package uses components/flag-icons.

It works fine with v3.5.0 (https://packagist.org/packages/components/flag-icon-css#3.5.0) of this package, however, with newer versions the flag-icon.css has been renamed to flag-icons.css, resulting in a 404 when trying to load the flag icons.

I would suggest to either fix this by changing the flag-icon.css in this package to flag-icons.css, or lock the flag-icon-css package to 3.5.0.

Prerequisites

Steps to reproduce the issue

  1. I include the latest yii2-icons.
  2. I load the assets to the view via \kartik\icons\Icon::map($this);
  3. I load the page, and it does a request to http://localhost:3001/assets/2cb9e3a/css/flag-icon.css , which doesn't exist. However, http://localhost:3001/assets/2cb9e3a/css/flag-icon**s**.css does exist.

Expected behavior and actual behavior

When I follow those steps, I see... flag-icon.css gets loaded, which is incorrect when the latest components/flag-icons-css is used.

I was expecting... I expect the flag-icons.css to get loaded, which is the standard in the latest components/flag-icon-css package.

Environment

Browsers

Operating System

Libraries

Isolating the problem

KevinVanH commented 3 months ago

Fixed by https://github.com/kartik-v/yii2-icons/pull/54