search

kartik-v / yii2-markdown

Advanced Markdown editing and conversion utilities for Yii Framework 2.0
http://demos.krajee.com/markdown
Other
89 stars 41 forks source link

beforeProcess and afterProcess callables? #17

Open drenty opened 10 years ago

drenty commented 10 years ago

Markdown has a custom option which is great, but it would be better if you could pass callables as options to change the markup either before of after calling process().

That would provide more flexibility.

I can open a PR if you're interested.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1714947-beforeprocess-and-afterprocess-callables?utm_campaign=plugin&utm_content=tracker%2F638644&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F638644&utm_medium=issues&utm_source=github).
kartik-v commented 10 years ago

Yes - a PR would help.

Note though... I have a plan to upgrade the Markdown parser using cebe's Markdown parser down the line (maybe sometime in May when he adds the MarkdownExtra support).

drenty commented 10 years ago

Ok cool, cebe's Markdown parser has a very elegant way to extend the language.

I'll submit a PR to be able to extend it with callables before you switch.