search

kartik-v / yii2-markdown

Advanced Markdown editing and conversion utilities for Yii Framework 2.0
http://demos.krajee.com/markdown
Other
89 stars 41 forks source link

I18N support #3

Closed chris68 closed 10 years ago

chris68 commented 10 years ago

It would be extremely helpful if the module would provide the base for I18N (i.e. use yii::t()).

I would be more than happy to provide the German translations then.

kartik-v commented 10 years ago

Will do this a bit later when I find time. Thanks for the suggestion.

In the interim, you could define translations in your app and it should get detected. Module uses Yii::t('app', $message) when outputting text in many places.

kartik-v commented 10 years ago

@chris68 I have started the implementation of i18n. Could you submit a pull request with the German Messages configuration, so that I could test it. Check the messages folder for en-US messages and use that as a base.

chris68 commented 10 years ago

Will take care of that later in the evening. Thanks a lot for your ultra-fast responses!

kartik-v commented 10 years ago

@chris68 thanks. I will slightly make the code better for i18n and merge this PR a bit later.

kartik-v commented 10 years ago

Closed via commit 7f8dc0b and 8f2a16c. If you could help with any other language translations let know. You need to set Yii::$app->language before using the extension.