search

kartik-v / yii2-tree-manager

An advanced tree management module using nested sets for Yii 2.
http://demos.krajee.com/tree-manager
Other
150 stars 107 forks source link

Fix260b #262

Open BillHeaton opened 4 years ago

BillHeaton commented 4 years ago

Scope

This pull request includes a

Changes

The following changes were made (this change is also documented in the change log):

Separates the isAdmin view from the !isAdmin (i.e. user detail). When in isAdmin mode a button is present in the detail screen to flip to the other mode.

TODO

Related Issues

https://github.com/kartik-v/yii2-tree-manager/issues/260

BillHeaton commented 4 years ago

This enhancement is mostly working. !isAdmin mode (i.e. user view) is complete and the a new read-only detail view displays.

isAdmin mode has a weird bug. The first detail screen displays correctly. Pressing the flip view button doesn't apparently work but the session variable is updated. Refreshing the screen will show the new mode.

I suspect it's a session problem. May need to move the view mode into the parameters.

kartik-v commented 4 years ago

Thanks - went quickly through. Let me know when you have the tested/corrected/updated version.

BillHeaton commented 4 years ago

Will do. I plan on moving the view mode into parameters as it'll be simpler than than the session variable.

BillHeaton commented 4 years ago

@kartik-v Code Complete. I'm testing now.

I would like to write up a how-to on adding buttons to the detail screen. How do I get it to you and what format would you like?

BillHeaton commented 4 years ago

@kartik-v Testing complete. I was able to override both the Admin detail and the User detail.

kartik-v commented 4 years ago

Thanks @BillHeaton - I will take this and add some updates over this PR.

BillHeaton commented 4 years ago

I'm chasing a problem which seems like something not being initialized. Symptom: Switch to another item in the tree view and it displays an endless "Loading" icon. Only manifests when I override 'nodeView' and 'nodeUser'.

The workaround is to press the switch view button which works and the problem resolves itself.

On Jan 6, 2020, at 8:59 PM, Kartik Visweswaran notifications@github.com wrote:

Thanks @BillHeaton https://github.com/BillHeaton - I will take this and add some updates over this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kartik-v/yii2-tree-manager/pull/262?email_source=notifications&email_token=AAUVA2MEP4URFGJ3CNSVYYDQ4QD2HA5CNFSM4JX2KWV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHWMXQ#issuecomment-571434590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUVA2L2JAIZNVGI3VL5ELLQ4QD2HANCNFSM4JX2KWVQ.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

BillHeaton commented 4 years ago

@kartik-v You was going to do some updates over this PR?

kartik-v commented 4 years ago

Hi @BillHeaton -- I had tested this PR initially - but found some tests were failing and then did not get time to dig into that. Have you managed to test the functionality you included?

kartik-v commented 4 years ago

I have marking this issue with an enhancement label - so that we have this issue active and do not have the stale bot marking it stale.

BillHeaton commented 4 years ago

Tested mostly with only the one issue to track down. What was the problems you were having with testing? Was off working on rebasing a project to pure bootstrap 4 and just finished so can spend some more time on it soon.

kartik-v commented 4 years ago

The rendering of node detail was not happening (something broken I suppose on the JS initialization). As I said did not get time to dig in as well.

BillHeaton commented 4 years ago

Exactly! That's what I plan to chase. It's appears to be an initialization problem.

On Mar 9, 2020, at 10:15 AM, Kartik Visweswaran notifications@github.com wrote:

The rendering of node detail was not happening (something broken I suppose on the JS initialization). As I said did not get time to dig in as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kartik-v/yii2-tree-manager/pull/262?email_source=notifications&email_token=AAUVA2KEA4SNVGK477PEUXLRGUP2TA5CNFSM4JX2KWV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIFNZY#issuecomment-596661991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUVA2MNNUSZPHVS5SIO3X3RGUP2TANCNFSM4JX2KWVQ.