search

kartik-v / yii2-widget-activeform

Enhanced Yii2 active-form and active-field with full bootstrap styling support (sub repo split from yii2-widgets).
http://demos.krajee.com/widget-details/active-form
Other
64 stars 35 forks source link

ActiveField::getToggleFieldList() calls same code twice #89

Closed vercotux closed 6 years ago

vercotux commented 7 years ago

Line 1444:

if ($asButtonGroup && $checked) {
    Html::addCssClass($labelOptions, 'active');
}

Line 1455:

if ($checked && $asButtonGroup) {
    Html::addCssClass($labelOptions, 'active');
}

I don't see any particular reason for this, so I assume it's just some reminiscent code.

Enrica-r commented 6 years ago

I think so also. I can't see any reason. The second part could be removed but it's not urgent.

kartik-v commented 6 years ago

Thanks for the suggestion. Code will be updated.