kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
921 stars 47 forks source link

Preview 10 doesn't retain history properly #106

Closed LesterJitsi closed 2 weeks ago

LesterJitsi commented 2 months ago

As per title, Aural Preview 10 does not retain in history the number of items set in Preferences > History. I can't tell whether this was already present in a previous version.

As the sheer number of features in Aural 4 is growing steadily, I hope I'm not mistaking an intended behavior for an issue 😁 Maybe the number of recent items is reset when they exceed 25 (or whatever set in Prefs > History)?

Screenshot 2024-09-17 alle 17 35 18_1

kartik-venugopal commented 2 months ago

Hey Lester, to be honest, that is probably a genuine bug, but that is to be expected in all the v4 preview releases 😄

Since it is not a mature release, many features (including core features like History) are not working 100%.

That's why I include a disclaimer on the preview release page 😁

In any case, I will get around to fixing it ... hopefully soon!

kartik-venugopal commented 2 weeks ago

I tried adding more than 25 items with no limit set ... worked fine (retained all 30 something of them). Then set the limit to 25 in preferences. Noticed that the oldest ones were deleted such that the most recent 25 items were retained. Added 2 more items. Noticed that the 2 oldest items were deleted.

It is working exactly as expected 😄

You need to first have up to 25 items (or more) for the limit to take effect. Then once the limit is set, it will delete the oldest items as new ones are added.

LesterJitsi commented 2 weeks ago

It is working exactly as expected 😄 You need to first have up to 25 items (or more) for the limit to take effect.

Not on my system (Ventura at the time I posted) and not with Preview 10 (I can't test it again right now, but of course I did before posting). Anyway Preview 12 on Sonoma works fine. Thank you!

kartik-venugopal commented 2 weeks ago

It is working exactly as expected 😄 You need to first have up to 25 items (or more) for the limit to take effect.

Not on my system (Ventura at the time I posted) and not with Preview 10 (I can't test it again right now, but of course I did before posting). Anyway Preview 12 on Sonoma works fine. Thank you!

Interesting ... I don't remember fixing anything 😄 Thanks for letting me know!