search

kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
760 stars 43 forks source link

ffmpeg.c, ffmpeg.h, config.h (after compilation of ffmpeg) are missing from source code tree #26

Closed hemmlj closed 3 years ago

hemmlj commented 3 years ago

The files "ffmpeg.h" and "ffmpeg.c" are missing from the source code tree as ffmpeg v4.3.1 is delivered as "ffmpeg-sourceCode.bz2" in Resources/ffmpeg folder. So compiling for ffmpeg needs to be done with build-ffmpeg.sh (read the README.txt in Resources/ffmpeg folder). So far, so fine. But afterwards "config.h" is still missing! Please note where to find that file. Thanks!

kartik-venugopal commented 3 years ago

Hi, thanks so much for letting me know about this ! Those 2 files were being referenced from a duplicate project somewhere else on my hard drive, so I didn't catch the error before this.

I have added those 2 files (ffmpeg.c and .h) now under Aural/Source. Please refer to this Git commit.

PS - There is no config.h that I'm aware of. I searched my entire source tree ... there is no config.h file. Which build step gave you this particular error ? Can you share a build log or screenshot showing the error ?

Also, you don't have to build ffmpeg from scratch. There are already .dylib files ready to use, under Aural/Frameworks.

Please let me know if you have more errors or if you're able to do a successful build ... I'll wait to close the issue until then.

hemmlj commented 3 years ago

OK that issues seems to be solved now.

kartik-venugopal commented 3 years ago

Cool, thanks for letting me know.

I found that config.h was referenced from some of the ffmpeg C code (as an #include), but I think the reason the code compiles without the file present is because it looks like a conditional include (this one is from libavutil/bswap.h):

`#ifdef HAVE_AV_CONFIG_H

include "config.h"`

Anyway, glad it's all fixed now. I've closed the issue.

Cheers !

hemmlj commented 3 years ago

It definitely compiles now. Thank you!