search

kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
822 stars 44 forks source link

auxMixer #3

Closed terenzeyuen closed 7 years ago

terenzeyuen commented 7 years ago

Great work! I noticed in initPlayer you reconnectNodes to auxMixer instead of mainMixer. Any reasons for it as I can't seem to find any place in code that uses auxMixer (yet)?

kartik-venugopal commented 7 years ago

Hi Terenz,

Thanks for your feedback. Yes, I reconnect playerNode to aux mixer because the aux mixer is responsible for performing sample rate conversions and channel count conversions.

I cannot do this with main mixer, because there are other nodes (EQ, Pitch, etc), between the player and main mixer, so I had to insert an aux mixer to perform the conversions.

Hope this helps !

terenzeyuen commented 7 years ago

Thank you very much @maculateConception