search

kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
760 stars 43 forks source link

converted to Swift 4 #4

Closed dun198 closed 6 years ago

dun198 commented 6 years ago
kartik-venugopal commented 6 years ago

Hi Tobias,

Thanks for starting a Swift 4 fork and keeping this project on the cutting edge.

I'm curious how you got rid of the warnings.

BTW, sorry about the missing GIFs. I have uploaded them under /Resources. You can find them there now.

dun198 commented 6 years ago

Hey, Most warnings happened due to redundancy. For example in the catch phrase of the error handling you converted 'error' to type 'Error' with the 'as' operator while it already was of type Error. Also on some called functions I used the unserscore variable '_' which means 'I don't care about the variable'. So in this case the function gets executed, but Swift doesn't care about the return value, since it's not used in the code anyways.

kartik-venugopal commented 6 years ago

Ah ok, thanks. I'm still learning Swift, so that's good to know.

dun198 commented 6 years ago

You could probably create a swift 4 branch and merge it there. So my changes won't affect the master.

Yeah I started swift coding about 3 months ago, so I'm also new to it. Also learning C++ parallel to it. I'm just happy I finally found an interesting project I could learn from and also contribute to, so my progress can be useful as well.

kartik-venugopal commented 6 years ago

Ok, sounds good. I will create a Swift4 branch. Thanks.

It's good to have you contributing to Aural Player :) Have fun with it.

Are you from Germany ? Just curious.

P.S. The Developer-readme file is very old, so it may not be all that accurate. The code has undergone major refactoring after that was written, so go ahead and look at it (it is still useful) but just keep in mind that it is outdated.